Removed ip address logging

This commit is contained in:
mrfry 2021-05-09 09:45:37 +02:00
parent c1feb28f86
commit 168a36b538
6 changed files with 17 additions and 27 deletions

View file

@ -15,7 +15,7 @@ const testUser = {
created: new Date(), created: new Date(),
} }
export default function(options: Options): any { export default function (options: Options): any {
const { userDB, jsonResponse, exceptions } = options const { userDB, jsonResponse, exceptions } = options
const renderLogin = (req, res) => { const renderLogin = (req, res) => {
@ -32,8 +32,7 @@ export default function(options: Options): any {
} }
} }
return function(req, res, next) { return function (req, res, next) {
const ip = req.headers['cf-connecting-ip'] || req.connection.remoteAddress
const sessionID = req.cookies.sessionID const sessionID = req.cookies.sessionID
const isException = exceptions.some((exc) => { const isException = exceptions.some((exc) => {
return req.url.split('?')[0] === exc return req.url.split('?')[0] === exc
@ -93,7 +92,7 @@ export default function(options: Options): any {
logger.DebugLog(`ID #${user.id}: ${req.url}`, 'auth', 1) logger.DebugLog(`ID #${user.id}: ${req.url}`, 'auth', 1)
UpdateAccess(userDB, user, ip, sessionID) UpdateAccess(userDB, user, sessionID)
dbtools.Update( dbtools.Update(
userDB, userDB,
@ -110,7 +109,7 @@ export default function(options: Options): any {
userDB, userDB,
'users', 'users',
{ {
lastIP: ip, lastIP: '0.0.0.0',
lastAccess: utils.GetDateString(), lastAccess: utils.GetDateString(),
}, },
{ {
@ -122,16 +121,16 @@ export default function(options: Options): any {
} }
} }
function UpdateAccess(db, user, ip, sessionID) { function UpdateAccess(db, user, sessionID) {
const accesses = dbtools.Select(db, 'accesses', { const accesses = dbtools.Select(db, 'accesses', {
userId: user.id, userId: user.id,
ip: ip, ip: '0.0.0.0',
}) })
if (accesses.length === 0) { if (accesses.length === 0) {
dbtools.Insert(db, 'accesses', { dbtools.Insert(db, 'accesses', {
userID: user.id, userID: user.id,
ip: ip, ip: '0.0.0.0',
sessionID: sessionID, sessionID: sessionID,
date: utils.GetDateString(), date: utils.GetDateString(),
}) })

View file

@ -37,7 +37,6 @@ function setup(data: SubmoduleData): void {
) )
} }
const ip = req.headers['cf-connecting-ip'] || req.connection.remoteAddress
const user: User = req.session.user const user: User = req.session.user
utils.AppendToFile( utils.AppendToFile(
@ -47,7 +46,6 @@ function setup(data: SubmoduleData): void {
{ {
...req.body, ...req.body,
userID: user ? user.id : 'no user', userID: user ? user.id : 'no user',
ip: ip,
}, },
null, null,
2 2

View file

@ -727,8 +727,6 @@ function setup(data: SubmoduleData): any {
utils.WriteFile('[]', registeredScriptsFile) utils.WriteFile('[]', registeredScriptsFile)
} }
const ip: any =
req.headers['cf-connecting-ip'] || req.connection.remoteAddress
const ua: any = req.headers['user-agent'] const ua: any = req.headers['user-agent']
const registeredScripts = utils.ReadJSON(registeredScriptsFile) const registeredScripts = utils.ReadJSON(registeredScriptsFile)
const { cid, uid, version, installSource, date } = req.body const { cid, uid, version, installSource, date } = req.body
@ -743,7 +741,6 @@ function setup(data: SubmoduleData): any {
version: version, version: version,
installSource: installSource, installSource: installSource,
date: date, date: date,
ip: ip,
userAgent: ua, userAgent: ua,
} }

View file

@ -53,7 +53,7 @@ function setup(data: SubmoduleData): any {
}) })
}) })
app.post('/getpw', function(req: Request, res: any) { app.post('/getpw', function (req: Request, res: any) {
logger.LogReq(req) logger.LogReq(req)
const requestingUser = req.session.user const requestingUser = req.session.user
@ -111,13 +111,9 @@ function setup(data: SubmoduleData): any {
app.post('/login', (req: Request, res: any) => { app.post('/login', (req: Request, res: any) => {
logger.LogReq(req) logger.LogReq(req)
const pw = req.body.pw const pw = req.body.pw
? req.body.pw ? req.body.pw.replace(/'/g, '').replace(/"/g, '').replace(/;/g, '')
.replace(/'/g, '')
.replace(/"/g, '')
.replace(/;/g, '')
: false : false
const isScript = req.body.script const isScript = req.body.script
const ip = req.headers['cf-connecting-ip'] || req.connection.remoteAddress
const user: User = dbtools.Select(userDB, 'users', { const user: User = dbtools.Select(userDB, 'users', {
pw: pw, pw: pw,
})[0] })[0]
@ -156,7 +152,7 @@ function setup(data: SubmoduleData): any {
'users', 'users',
{ {
loginCount: user.loginCount + 1, loginCount: user.loginCount + 1,
lastIP: ip, lastIP: '0.0.0.0',
lastLogin: utils.GetDateString(), lastLogin: utils.GetDateString(),
}, },
{ {
@ -166,7 +162,7 @@ function setup(data: SubmoduleData): any {
dbtools.Insert(userDB, 'sessions', { dbtools.Insert(userDB, 'sessions', {
id: sessionID, id: sessionID,
ip: ip, ip: '0.0.0.0',
userID: user.id, userID: user.id,
isScript: isScript ? 1 : 0, isScript: isScript ? 1 : 0,
createDate: utils.GetDateString(), createDate: utils.GetDateString(),

View file

@ -135,7 +135,7 @@ function removePossibleAnswersDuplicates(path) {
const dataA = utils.ReadJSON(currPath) const dataA = utils.ReadJSON(currPath)
currIndex++ currIndex++
printProgressBar(currIndex, count) printProgressBar(currIndex, count - 1)
contents.forEach((currFile2) => { contents.forEach((currFile2) => {
const currPath2 = path + '/' + currDir + '/' + currFile2 const currPath2 = path + '/' + currDir + '/' + currFile2

View file

@ -102,11 +102,11 @@ function expandWithSpaces(text, count) {
function LogReq(req: Request, toFile?: boolean, statusCode?: string): void { function LogReq(req: Request, toFile?: boolean, statusCode?: string): void {
try { try {
let ip: any = const ip: any =
req.headers['cf-connecting-ip'] || req.connection.remoteAddress req.headers['cf-connecting-ip'] || req.connection.remoteAddress
if (!toFile) { // if (!toFile) {
ip = expandWithSpaces(ip, 39) // ip = expandWithSpaces(ip, 39)
} // }
const nolog = noLogips.some((noLogip) => { const nolog = noLogips.some((noLogip) => {
return ip.includes(noLogip) return ip.includes(noLogip)
}) })
@ -114,7 +114,7 @@ function LogReq(req: Request, toFile?: boolean, statusCode?: string): void {
return return
} }
let logEntry = logHashed(ip) let logEntry = '' // logHashed(ip)
let dl = DELIM let dl = DELIM
if (req.url.includes('lred')) { if (req.url.includes('lred')) {
dl += C('red') dl += C('red')